linux-kernel - Re: [PATCH] iio: adc: stm32: Fix missing return in booster error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 13 Sep 2020 10:45:05 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-iio@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Greg KH <greg@...ah.com>
Subject: Re: [PATCH] iio: adc: stm32: Fix missing return in booster error
 path

On Thu, 10 Sep 2020 10:52:07 +0200
Krzysztof Kozlowski <krzk@...nel.org> wrote:

> Conversion of error paths to dev_err_probe() dropped one return
> statement.  The driver will continue to probe if getting booster
> regulator fails.
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Fixes: ce30eeb613cb ("iio: adc: stm32: Simplify with dev_err_probe()")
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke at it.

Thanks,

Jonathan

> 
> ---
> 
> Commit sha from linux-next.

This is applying to an (in theory) non rebasing tree, so hopefully
that will remain stable!

> ---
>  drivers/iio/adc/stm32-adc-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 3f27b4817a42..6a0338d33bd8 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -595,7 +595,7 @@ static int stm32_adc_core_switches_probe(struct device *dev,
>  		if (IS_ERR(priv->booster)) {
>  			ret = PTR_ERR(priv->booster);
>  			if (ret != -ENODEV)
> -				dev_err_probe(dev, ret, "can't get booster\n");
> +				return dev_err_probe(dev, ret, "can't get booster\n");
>  
>  			priv->booster = NULL;
>  		}