linux-kernel - Re: [PATCH] tee/tee_shm.c: Fix error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAFqt6zYA4srnsGx+OzrzVuzasOvUQR+dN0nmVZcv1zVeotxKUA@mail.gmail.com>
Date:   Sun, 13 Sep 2020 18:31:08 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     op-tee@...ts.trustedfirmware.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        Jens Wiklander <jens.wiklander@...aro.org>,
        John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH] tee/tee_shm.c: Fix error handling path

On Sun, Sep 13, 2020 at 2:00 PM Markus Elfring <Markus.Elfring@....de> wrote:
>
> > When shm->num_pages <= 0, we should avoid calling
> > release_registered_pages() in error handling path.
>
> * Would an imperative wording become helpful for the change description?
>
> * I suggest to add the tag “Fixes” to the commit message.

Sure. Will address both in v2.
>
> Regards,
> Markus