linux-kernel - Re: [PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 12 Sep 2020 23:00:48 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     agross@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] clk: qcom: gcc-msm8939: remove defined but not used
 variables

On Thu 10 Sep 20:37 CDT 2020, Jason Yan wrote:

> This addresses the following gcc warning with "make W=1":
> 
> drivers/clk/qcom/gcc-msm8939.c:610:32: warning:
> ‘gcc_xo_gpll6_gpll0a_map’ defined but not used
> [-Wunused-const-variable=]
>  static const struct parent_map gcc_xo_gpll6_gpll0a_map[] = {
>                                 ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gcc-msm8939.c:598:32: warning: ‘gcc_xo_gpll6_gpll0_map’
> defined but not used [-Wunused-const-variable=]
>  static const struct parent_map gcc_xo_gpll6_gpll0_map[] = {
>                                 ^~~~~~~~~~~~~~~~~~~~~~
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/clk/qcom/gcc-msm8939.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 778354f82b1e..39ebb443ae3d 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -595,24 +595,12 @@ static const struct clk_parent_data gcc_xo_gpll1_emclk_sleep_parent_data[] = {
>  	{ .fw_name = "sleep_clk", .name = "sleep_clk" },
>  };
>  
> -static const struct parent_map gcc_xo_gpll6_gpll0_map[] = {
> -	{ P_XO, 0 },
> -	{ P_GPLL6, 1 },
> -	{ P_GPLL0, 2 },
> -};
> -
>  static const struct clk_parent_data gcc_xo_gpll6_gpll0_parent_data[] = {
>  	{ .fw_name = "xo" },
>  	{ .hw = &gpll6_vote.hw },
>  	{ .hw = &gpll0_vote.hw },
>  };
>  
> -static const struct parent_map gcc_xo_gpll6_gpll0a_map[] = {
> -	{ P_XO, 0 },
> -	{ P_GPLL6, 1 },
> -	{ P_GPLL0_AUX, 2 },
> -};
> -
>  static const struct clk_parent_data gcc_xo_gpll6_gpll0a_parent_data[] = {
>  	{ .fw_name = "xo" },
>  	{ .hw = &gpll6_vote.hw },
> -- 
> 2.25.4
>