linux-kernel - Re: [PATCH] MIPS: Remove unused BOOT_MEM_INIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2349dc3-8086-64ee-e2d7-7a69afac6623@flygoat.com>
Date:   Mon, 14 Sep 2020 12:32:07 +0800
From:   Jiaxun Yang <jiaxun.yang@...goat.com>
To:     Youling Tang <tangyouling@...ngson.cn>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Remove unused BOOT_MEM_INIT_RAM



在 2020/9/12 9:59, Youling Tang 写道:
> Commit a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") left
> the BOOT_MEM_INIT_RAM unused, remove it.
>
> Signed-off-by: Youling Tang <tangyouling@...ngson.cn>
> ---
>   arch/mips/include/asm/bootinfo.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/bootinfo.h b/arch/mips/include/asm/bootinfo.h
> index 147c932..39196ae 100644
> --- a/arch/mips/include/asm/bootinfo.h
> +++ b/arch/mips/include/asm/bootinfo.h
> @@ -91,7 +91,6 @@ extern unsigned long mips_machtype;
>   #define BOOT_MEM_RAM		1
>   #define BOOT_MEM_ROM_DATA	2
>   #define BOOT_MEM_RESERVED	3
> -#define BOOT_MEM_INIT_RAM	4

If you're willing to remove that you'd better turn the memtype struct
into a enum.

Btw: It seems you've done a lot of minor clean-up works recently,
if you'd like to I think you can try to turn all the platforms into memblock
and remove all these gules between memblock and legacy code.

Thanks.

- Jiaxun

>   #define BOOT_MEM_NOMAP		5
>   
>   extern void add_memory_region(phys_addr_t start, phys_addr_t size, long type);