linux-kernel - Re: [PATCH] arc: plat-hsdk: fix kconfig dependency warning when !RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Sep 2020 19:50:43 +0000
From:   Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:     Necip Fazil Yildiran <fazilyildiran@...il.com>
CC:     "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "paul@...zz.com" <paul@...zz.com>,
        "jeho@...utexas.edu" <jeho@...utexas.edu>
Subject: Re: [PATCH] arc: plat-hsdk: fix kconfig dependency warning when
 !RESET_CONTROLLER

On 9/14/20 4:46 AM, Necip Fazil Yildiran wrote:
> When ARC_SOC_HSDK is enabled and RESET_CONTROLLER is disabled, it results
> in the following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for RESET_HSDK
>   Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y] && (ARC_SOC_HSDK [=y] || COMPILE_TEST [=n])
>   Selected by [y]:
>   - ARC_SOC_HSDK [=y] && ISA_ARCV2 [=y]
>
> The reason is that ARC_SOC_HSDK selects RESET_HSDK without depending on or
> selecting RESET_CONTROLLER while RESET_HSDK is subordinate to
> RESET_CONTROLLER.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: a528629dfd3b ("ARC: [plat-hsdk] select CONFIG_RESET_HSDK from Kconfig")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>


Applied to for-curr

Thx,
-Vineet

> ---
>  arch/arc/plat-hsdk/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arc/plat-hsdk/Kconfig b/arch/arc/plat-hsdk/Kconfig
> index ce8101834518..6b5c54576f54 100644
> --- a/arch/arc/plat-hsdk/Kconfig
> +++ b/arch/arc/plat-hsdk/Kconfig
> @@ -8,5 +8,6 @@ menuconfig ARC_SOC_HSDK
>  	select ARC_HAS_ACCL_REGS
>  	select ARC_IRQ_NO_AUTOSAVE
>  	select CLK_HSDK
> +	select RESET_CONTROLLER
>  	select RESET_HSDK
>  	select HAVE_PCI