[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200914200840.GA152914@bogus>
Date: Mon, 14 Sep 2020 14:08:40 -0600
From: Rob Herring <robh@...nel.org>
To: Piyush Mehta <piyush.mehta@...inx.com>
Cc: axboe@...nel.dk, p.zabel@...gutronix.de, linux-ide@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
git@...inx.com, sgoud@...inx.com, michal.simek@...inx.com
Subject: Re: [PATCH 2/2] dt-bindings: ata: achi: ceva: Update documentation
for CEVA Controller
On Wed, Sep 02, 2020 at 12:35:48PM +0530, Piyush Mehta wrote:
> This patch updates the documentation for the CEVA controller for adding
> the required properties for 'phys' and 'resets'.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@...inx.com>
> ---
> Documentation/devicetree/bindings/ata/ahci-ceva.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> index 7561cc4..f01d317 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> @@ -35,6 +35,10 @@ Required properties:
> ceva,pN-retry-params = /bits/ 16 <RIT RCT>;
> RIT: Retry Interval Timer.
> RCT: Rate Change Timer.
> + - phys: phandle for the PHY device
> + - phy-names: Should be "sata-phy"
> + - resets: phandle to the reset controller for the SATA IP
> + - reset-names: Should be "sata_rst".
The names here are rather pointless. You don't really need them if only
1 entry.
>
> Optional properties:
> - ceva,broken-gen2: limit to gen1 speed instead of gen2.
> @@ -56,4 +60,8 @@ Examples:
> ceva,p1-burst-params = /bits/ 8 <0x0A 0x08 0x4A 0x06>;
> ceva,p1-retry-params = /bits/ 16 <0x0216 0x7F06>;
> ceva,broken-gen2;
> + phy-names = "sata-phy";
> + phys = <&psgtr 1 PHY_TYPE_SATA 1 1>;
> + reset-names = "sata_rst";
> + resets = <&zynqmp_reset ZYNQMP_RESET_SATA>;
> };
> --
> 2.7.4
>
Powered by blists - more mailing lists