linux-kernel - Re: [PATCH] opp: Allow opp-level to be set to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200914201132.GA163547@gerhold.net>
Date:   Mon, 14 Sep 2020 22:11:32 +0200
From:   Stephan Gerhold <stephan@...hold.net>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd <sboyd@...nel.org>, linux-pm@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Rafael Wysocki <rjw@...ysocki.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] opp: Allow opp-level to be set to 0

On Fri, Sep 11, 2020 at 03:19:53PM +0530, Viresh Kumar wrote:
> The DT bindings don't put such a constraint, nor should the kernel. It
> is perfectly fine for opp-level to be set to 0, if we need to put the
> performance state votes for a domain for a particular OPP.
> 
> Reported-by: Stephan Gerhold <stephan@...hold.net>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

I tried adding an opp-level = <0> and voting for it using required-opps
for some of the OPPs in the CPU OPP table and it seems to work fine now.

Tested-by: Stephan Gerhold <stephan@...hold.net>

Just need to solve the "enable power domains" problem now :)

Thanks!
Stephan

> ---
>  drivers/opp/core.c |  3 ---
>  drivers/opp/of.c   | 20 +++++++-------------
>  2 files changed, 7 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> index 214c1619b445..2483e765318a 100644
> --- a/drivers/opp/core.c
> +++ b/drivers/opp/core.c
> @@ -2117,9 +2117,6 @@ int dev_pm_opp_xlate_performance_state(struct opp_table *src_table,
>  	int dest_pstate = -EINVAL;
>  	int i;
>  
> -	if (!pstate)
> -		return 0;
> -
>  	/*
>  	 * Normally the src_table will have the "required_opps" property set to
>  	 * point to one of the OPPs in the dst_table, but in some cases the
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index e72753be7dc7..87f839a1899a 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -842,7 +842,7 @@ static struct dev_pm_opp *_opp_add_static_v2(struct opp_table *opp_table,
>  static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
>  {
>  	struct device_node *np;
> -	int ret, count = 0, pstate_count = 0;
> +	int ret, count = 0;
>  	struct dev_pm_opp *opp;
>  
>  	/* OPP table is already initialized for the device */
> @@ -876,20 +876,14 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
>  		goto remove_static_opp;
>  	}
>  
> -	list_for_each_entry(opp, &opp_table->opp_list, node)
> -		pstate_count += !!opp->pstate;
> -
> -	/* Either all or none of the nodes shall have performance state set */
> -	if (pstate_count && pstate_count != count) {
> -		dev_err(dev, "Not all nodes have performance state set (%d: %d)\n",
> -			count, pstate_count);
> -		ret = -ENOENT;
> -		goto remove_static_opp;
> +	list_for_each_entry(opp, &opp_table->opp_list, node) {
> +		/* Any non-zero performance state would enable the feature */
> +		if (opp->pstate) {
> +			opp_table->genpd_performance_state = true;
> +			break;
> +		}
>  	}
>  
> -	if (pstate_count)
> -		opp_table->genpd_performance_state = true;
> -
>  	return 0;
>  
>  remove_static_opp:
> -- 
> 2.25.0.rc1.19.g042ed3e048af
>