linux-kernel - Re: [PATCH net-next] net: qlcnic: remove unused variable 'val' in qlcnic_83xx_cam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200914.134427.1470378665038529043.davem@davemloft.net>
Date:   Mon, 14 Sep 2020 13:44:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zhangchangzhong@...wei.com
Cc:     shshaikh@...vell.com, manishc@...vell.com,
        GR-Linux-NIC-Dev@...vell.com, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: qlcnic: remove unused variable 'val' in
 qlcnic_83xx_cam_unlock()

From: Zhang Changzhong <zhangchangzhong@...wei.com>
Date: Mon, 14 Sep 2020 21:24:39 +0800

> Fixes the following W=1 kernel build warning(s):
> 
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:661:6: warning:
>  variable 'val' set but not used [-Wunused-but-set-variable]
>   661 |  u32 val;
>       |      ^~~
> 
> After commit 7f9664525f9c ("qlcnic: 83xx memory map and HW access
> routines"), variable 'val' is never used in qlcnic_83xx_cam_unlock(), so
> removing it to avoid build warning.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

Applied.