linux-kernel - Re: [PATCH v2 12/14] habanalabs/gaudi: Add ethtool support using coresight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf13soRfPcyi219sfFmubQJDhSmgMbJBvmTvSq3z9fivxLA@mail.gmail.com>
Date:   Mon, 14 Sep 2020 23:53:22 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        netdev@...r.kernel.org, SW_Drivers <SW_Drivers@...ana.ai>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Omer Shpigelman <oshpigelman@...ana.ai>
Subject: Re: [PATCH v2 12/14] habanalabs/gaudi: Add ethtool support using coresight

On Mon, Sep 14, 2020 at 11:07 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 14 Sep 2020 03:24:13 +0200 Andrew Lunn wrote:
> > > +static void gaudi_nic_get_internal_stats(struct net_device *netdev, u64 *data)
> > > +{
> > > +   struct gaudi_nic_device **ptr = netdev_priv(netdev);
> > > +   struct gaudi_nic_device *gaudi_nic = *ptr;
> > > +   struct hl_device *hdev = gaudi_nic->hdev;
> > > +   u32 port = gaudi_nic->port;
> > > +   u32 num_spmus;
> > > +   int i;
> > > +
> > > +   num_spmus = (port & 1) ? NIC_SPMU1_STATS_LEN : NIC_SPMU0_STATS_LEN;
> > > +
> > > +   gaudi_sample_spmu_nic(hdev, port, num_spmus, data);
> > > +   data += num_spmus;
> > > +
> > > +   /* first entry is title */
> > > +   data[0] = 0;
> >
> > You have been looking at statistics names recently. What do you think
> > of this data[0]?
>
> Highly counter-productive, users will commonly grep for statistics.
> Header which says "TX stats:" is a bad idea.
ok, thanks for the input, we will fix that.
Oded