linux-kernel - Re: linux-next: build warning after merge of the dmaengine tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200914053004.GB2968@vkoul-mobl>
Date:   Mon, 14 Sep 2020 11:00:04 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Brad Kim <brad.kim@...ive.com>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the dmaengine tree

Hi Stephen,

On 14-09-20, 14:29, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/dma/sf-pdma/sf-pdma.c: In function 'sf_pdma_donebh_tasklet':
> drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc' [-Wunused-variable]
>   287 |  struct sf_pdma_desc *desc = chan->desc;
>       |                       ^~~~
> 
> Introduced by commit
> 
>   8f6b6d060602 ("dmaengine: sf-pdma: Fix an error that calls callback twice")

Thanks for the report. The function directly uses chan->desc, so yes
this can be removed, Sending patch shortly

Thanks
-- 
~Vinod