linux-kernel - Re: [PATCH v18 2/3] drivers: input:keyboard: Add mtk keypad driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200914055315.GJ1665100@dtor-ws>
Date:   Sun, 13 Sep 2020 22:53:15 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Fengping Yu <fengping.yu@...iatek.com>
Cc:     Yingjoe Chen <yingjoe.chen@...iatek.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Marco Felsch <m.felsch@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>, linux-input@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v18 2/3] drivers: input:keyboard: Add mtk keypad driver

Hi Fengping,

On Wed, Sep 09, 2020 at 03:22:00PM +0800, Fengping Yu wrote:
> From: "fengping.yu" <fengping.yu@...iatek.com>
> 
> This patch adds matrix keypad support for Mediatek SoCs.

I am generally happy with the driver, however I do not believe this will
be the only Mediatek driver ever. Do you think we could rename it to
mt6779-keypad.c and use mt6779_keypad_ as prefix for function names?

Thanks!

-- 
Dmitry