linux-kernel - Re: [Cocci] [RFC PATCH] scripts: coccicheck: Improve error feedback when coccicheck fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2009140913480.2357@hadrien>
Date:   Mon, 14 Sep 2020 09:14:09 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Markus Elfring <Markus.Elfring@....de>
cc:     Sumera Priyadarsini <sylphrenadin@...il.com>,
        Coccinelle <cocci@...teme.lip6.fr>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Cocci] [RFC PATCH] scripts: coccicheck: Improve error feedback
 when coccicheck fails



On Mon, 14 Sep 2020, Markus Elfring wrote:

> >> How do you think about to use the following check variant?
> >>
> >> +	if [ "${DEBUG_FILE}" != '/dev/null' -a "${DEBUG_FILE}" != '' ]; then
> >
> > What difference does it make?
>
> I propose two implementation details for further development considerations.
>
> 1. Do you care if any variable names should be enclosed by curly brackets
>    in such script code?
>
> 2. A changeable value should be compared to two string literals here.
>    Varying contents should be enclosed by double quotes.
>    Constant values can be enclosed by single quotes, can't they?

I have no idea.  Why can't they be nclosed by double quotes as well?

julia