linux-kernel - Re: [PATCH -next] extcon: axp288: use module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <085e3e4a-863c-39e4-6028-1d87fff70800@redhat.com>
Date:   Mon, 14 Sep 2020 09:35:40 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Liu Shixin <liushixin2@...wei.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Chen-Yu Tsai <wens@...e.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] extcon: axp288: use module_platform_driver to
 simplify the code

Hi,

On 9/14/20 8:54 AM, Liu Shixin wrote:
> module_platform_driver() makes the code simpler by eliminating
> boilerplate code.
> 
> Signed-off-by: Liu Shixin <liushixin2@...wei.com>

Thank you for the cleanup, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>   drivers/extcon/extcon-axp288.c | 13 +------------
>   1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
> index 525345367260..fdb31954cf2b 100644
> --- a/drivers/extcon/extcon-axp288.c
> +++ b/drivers/extcon/extcon-axp288.c
> @@ -491,18 +491,7 @@ static struct platform_driver axp288_extcon_driver = {
>   		.pm = &axp288_extcon_pm_ops,
>   	},
>   };
> -
> -static int __init axp288_extcon_init(void)
> -{
> -	return platform_driver_register(&axp288_extcon_driver);
> -}
> -module_init(axp288_extcon_init);
> -
> -static void __exit axp288_extcon_exit(void)
> -{
> -	platform_driver_unregister(&axp288_extcon_driver);
> -}
> -module_exit(axp288_extcon_exit);
> +module_platform_driver(axp288_extcon_driver);
>   
>   MODULE_AUTHOR("Ramakrishna Pallala <ramakrishna.pallala@...el.com>");
>   MODULE_AUTHOR("Hans de Goede <hdegoede@...hat.com>");
>