linux-kernel - Re: [PATCH v4 2/3] media: i2c: ov772x: Add support for BT656 mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb9fcd11-21d9-1ce0-4247-a5f80d836da7@gmail.com>
Date:   Mon, 14 Sep 2020 10:55:48 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Jacopo Mondi <jacopo@...ndi.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org,
        Biju Das <biju.das.jz@...renesas.com>,
        Prabhakar <prabhakar.csengg@...il.com>
Subject: Re: [PATCH v4 2/3] media: i2c: ov772x: Add support for BT656 mode

Hello!

On 13.09.2020 21:42, Lad Prabhakar wrote:

> Add support to read the bus-type for V4L2_MBUS_BT656 and
> enable BT656 mode in the sensor if needed.

    Isn't it called BT.656?

> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@...renesas.com>
> ---
>   drivers/media/i2c/ov772x.c | 27 +++++++++++++++++++++------
>   1 file changed, 21 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
> index 551082aa7026..edd7c4c22225 100644
> --- a/drivers/media/i2c/ov772x.c
> +++ b/drivers/media/i2c/ov772x.c
[...]
> @@ -1427,16 +1434,24 @@ static int ov772x_probe(struct i2c_client *client)
>   		goto error_clk_put;
>   	}
>   
> -	bus_cfg.bus_type = V4L2_MBUS_PARALLEL;
> +	bus_cfg = (struct v4l2_fwnode_endpoint)
> +		  { .bus_type = V4L2_MBUS_BT656 };
>   	ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
>   	priv->bus_type = bus_cfg.bus_type;
>   	v4l2_fwnode_endpoint_free(&bus_cfg);
>   	if (ret) {
> -		/* For backward compatibility with the existing DT where
> -		 * bus-type isnt specified fallback to V4L2_MBUS_PARALLEL
> -		 */
> -		priv->bus_type = V4L2_MBUS_PARALLEL;
> -		dev_notice(&client->dev, "Falling back to V4L2_MBUS_PARALLEL mode\n");
> +		bus_cfg.bus_type = V4L2_MBUS_PARALLEL;
> +		ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
> +		priv->bus_type = bus_cfg.bus_type;
> +		v4l2_fwnode_endpoint_free(&bus_cfg);
> +		if (ret) {
> +			/* For backward compatibility with the existing DT where
> +			 * bus-type isnt specified fallback to V4L2_MBUS_PARALLEL
                                     ^^^^ isn't
    Could be fixed, while at it?

> +			 */
> +			priv->bus_type = V4L2_MBUS_PARALLEL;
> +			dev_notice(&client->dev,
> +				   "Falling back to V4L2_MBUS_PARALLEL mode\n");
> +		}
>   	}
>   
>   	ret = ov772x_video_probe(priv);

MBR, Sergei