linux-kernel - Re: [PATCH -next] ext2: Fix some kernel-doc warnings in balloc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200914083512.GB4863@quack2.suse.cz>
Date:   Mon, 14 Sep 2020 10:35:12 +0200
From:   Jan Kara <jack@...e.cz>
To:     Wang Hai <wanghai38@...wei.com>
Cc:     jack@...e.com, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ext2: Fix some kernel-doc warnings in balloc.c

On Fri 11-09-20 19:40:36, Wang Hai wrote:
> Fixes the following W=1 kernel build warning(s):
> 
> fs/ext2/balloc.c:203: warning: Excess function parameter 'rb_root' description in '__rsv_window_dump'
> fs/ext2/balloc.c:294: warning: Excess function parameter 'rb_root' description in 'search_reserve_window'
> fs/ext2/balloc.c:878: warning: Excess function parameter 'rsv' description in 'alloc_new_reservation'
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wang Hai <wanghai38@...wei.com>

Thanks. I've added the patch to my tree.

								Honza

> ---
>  fs/ext2/balloc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
> index fa9c951d3471..1f3f4326bf3c 100644
> --- a/fs/ext2/balloc.c
> +++ b/fs/ext2/balloc.c
> @@ -189,7 +189,7 @@ static void group_adjust_blocks(struct super_block *sb, int group_no,
>  
>  /**
>   * __rsv_window_dump() -- Dump the filesystem block allocation reservation map
> - * @rb_root:		root of per-filesystem reservation rb tree
> + * @root:		root of per-filesystem reservation rb tree
>   * @verbose:		verbose mode
>   * @fn:			function which wishes to dump the reservation map
>   *
> @@ -282,7 +282,7 @@ goal_in_my_reservation(struct ext2_reserve_window *rsv, ext2_grpblk_t grp_goal,
>  
>  /**
>   * search_reserve_window()
> - * @rb_root:		root of reservation tree
> + * @root:		root of reservation tree
>   * @goal:		target allocation block
>   *
>   * Find the reserved window which includes the goal, or the previous one
> @@ -859,7 +859,7 @@ static int find_next_reservable_window(
>   *
>   *	failed: we failed to find a reservation window in this group
>   *
> - *	@rsv: the reservation
> + *	@my_rsv: the reservation
>   *
>   *	@grp_goal: The goal (group-relative).  It is where the search for a
>   *		free reservable space should start from.
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR