linux-kernel - Re: [PATCH] mm: memcontrol: Correct the comment of mem_cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200914104642.GJ16999@dhcp22.suse.cz>
Date:   Mon, 14 Sep 2020 12:46:42 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     hannes@...xchg.org, vdavydov.dev@...il.com,
        akpm@...ux-foundation.org, cgroups@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: memcontrol: Correct the comment of mem_cgroup_iter()

On Sun 13-09-20 05:41:29, Miaohe Lin wrote:
> Since commit bbec2e15170a ("mm: rename page_counter's count/limit into
> usage/max"), the arg @reclaim has no priority field anymore.

The priority field has been removed by 9da83f3fc74b ("mm, memcg: clean
up reclaim iter array")
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Other than that
Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  mm/memcontrol.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 75cd1a1e66c8..a57aa0f42d40 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1138,9 +1138,9 @@ static __always_inline struct mem_cgroup *get_mem_cgroup_from_current(void)
>   * invocations for reference counting, or use mem_cgroup_iter_break()
>   * to cancel a hierarchy walk before the round-trip is complete.
>   *
> - * Reclaimers can specify a node and a priority level in @reclaim to
> - * divide up the memcgs in the hierarchy among all concurrent
> - * reclaimers operating on the same node and priority.
> + * Reclaimers can specify a node in @reclaim to divide up the memcgs
> + * in the hierarchy among all concurrent reclaimers operating on the
> + * same node.
>   */
>  struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root,
>  				   struct mem_cgroup *prev,
> -- 
> 2.19.1

-- 
Michal Hocko
SUSE Labs