linux-kernel - Re: [PATCH v5 03/10] fs/ntfs3: Add bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Sep 2020 03:38:45 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Konstantin Komarov <almaz.alexandrovich@...agon-software.com>,
        linux-fsdevel@...r.kernel.org, viro@...iv.linux.org.uk,
        linux-kernel@...r.kernel.org, pali@...nel.org, dsterba@...e.cz,
        aaptel@...e.com, rdunlap@...radead.org, mark@...mstone.com,
        nborisov@...e.com
Subject: Re: [PATCH v5 03/10] fs/ntfs3: Add bitmap

On Sun, Sep 13, 2020 at 11:43:50AM -0700, Joe Perches wrote:
> On Fri, 2020-09-11 at 17:10 +0300, Konstantin Komarov wrote:
> > This adds bitmap
> 
> $ make fs/ntfs3/
>   SYNC    include/config/auto.conf.cmd
>   CALL    scripts/checksyscalls.sh
>   CALL    scripts/atomic/check-atomics.sh
>   DESCEND  objtool
>   CC      fs/ntfs3/bitfunc.o
>   CC      fs/ntfs3/bitmap.o
> fs/ntfs3/bitmap.c: In function ‘wnd_rescan’:
> fs/ntfs3/bitmap.c:556:4: error: implicit declaration of function ‘page_cache_readahead_unbounded’; did you mean ‘page_cache_ra_unbounded’? [-Werror=implicit-function-declaration]
>   556 |    page_cache_readahead_unbounded(
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |    page_cache_ra_unbounded
> cc1: some warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:283: fs/ntfs3/bitmap.o] Error 1
> make[1]: *** [scripts/Makefile.build:500: fs/ntfs3] Error 2
> make: *** [Makefile:1792: fs] Error 2

That was only just renamed.  More concerningly, the documentation is
quite unambiguous:

 * This function is for filesystems to call when they want to start
 * readahead beyond a file's stated i_size.  This is almost certainly
 * not the function you want to call.  Use page_cache_async_readahead()
 * or page_cache_sync_readahead() instead.