linux-kernel - Re: [Linux-kernel-mentees] [PATCH] idr: remove WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200914110803.GL6583@casper.infradead.org>
Date:   Mon, 14 Sep 2020 12:08:03 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Anmol Karn <anmol.karan123@...il.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        syzbot+f7204dcf3df4bb4ce42c@...kaller.appspotmail.com
Subject: Re: [Linux-kernel-mentees] [PATCH] idr: remove WARN_ON_ONCE() when
 trying to check id

On Mon, Sep 14, 2020 at 12:47:24PM +0530, Anmol Karn wrote:
> idr_get_next() gives WARN_ON_ONCE() when it gets (id > INT_MAX) true
> and this happens when syzbot does fuzzing, and that warning is
> expected, but WARN_ON_ONCE() is not required here and, cecking
> the condition and returning NULL value would be suffice.
> 
> Reference: commit b9959c7a347 ("filldir[64]: remove WARN_ON_ONCE() for bad directory entries")
> Reported-and-tested-by: syzbot+f7204dcf3df4bb4ce42c@...kaller.appspotmail.com
> Link: https://syzkaller.appspot.com/bug?extid=f7204dcf3df4bb4ce42c 
> Signed-off-by: Anmol Karn <anmol.karan123@...il.com>

https://lore.kernel.org/netdev/20200605120037.17427-1-willy@infradead.org/