linux-kernel - Re: [PATCH] MIPS: Remove unused BOOT_MEM_INIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Sep 2020 13:08:56 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Youling Tang <tangyouling@...ngson.cn>
Cc:     Jiaxun Yang <jiaxun.yang@...goat.com>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Remove unused BOOT_MEM_INIT_RAM

On Mon, Sep 14, 2020 at 06:39:51PM +0800, Youling Tang wrote:
> 
> 
> On 09/14/2020 12:32 PM, Jiaxun Yang wrote:
> >
> >
> >在 2020/9/12 9:59, Youling Tang 写道:
> >>Commit a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") left
> >>the BOOT_MEM_INIT_RAM unused, remove it.
> >>
> >>Signed-off-by: Youling Tang <tangyouling@...ngson.cn>
> >>---
> >>  arch/mips/include/asm/bootinfo.h | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >>diff --git a/arch/mips/include/asm/bootinfo.h
> >>b/arch/mips/include/asm/bootinfo.h
> >>index 147c932..39196ae 100644
> >>--- a/arch/mips/include/asm/bootinfo.h
> >>+++ b/arch/mips/include/asm/bootinfo.h
> >>@@ -91,7 +91,6 @@ extern unsigned long mips_machtype;
> >>  #define BOOT_MEM_RAM        1
> >>  #define BOOT_MEM_ROM_DATA    2
> >>  #define BOOT_MEM_RESERVED    3
> >>-#define BOOT_MEM_INIT_RAM    4
> >
> >If you're willing to remove that you'd better turn the memtype struct
> >into a enum.
> >
> Hi  Jiaxun,
> Do you mean to modify it as follows?
> 
> enum boot_memtype {
>                 BOOT_MEM_RAM,
>                 BOOT_MEM_ROM_DATA,
>                 BOOT_MEM_RESERVED,
>                 BOOT_MEM_NOMAP,
> };

that's not worth the effort, we should convert from add_memory_region
to direct memblock_XXX calls and get rid of MIPS boot mem completely.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]