linux-kernel - Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fe50c76-8d78-c1fe-e8f5-b43eecd32db8@ti.com>
Date:   Mon, 14 Sep 2020 17:43:56 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Nishanth Menon <nm@...com>
CC:     Rob Herring <robh+dt@...nel.org>, Tero Kristo <t-kristo@...com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device
 tree nodes

Hi Nishanth,

On 14/09/20 5:22 pm, Nishanth Menon wrote:
> On 16:53-20200914, Kishon Vijay Abraham I wrote:
>> Hi Rob,
>>
>> On 02/09/20 1:07 pm, Kishon Vijay Abraham I wrote:
>>> Hi Rob,
>>>
>>> On 02/09/20 10:24 am, Kishon Vijay Abraham I wrote:
>>>> Hi Nishanth,
>>>>
>>>> On 01/09/20 8:22 pm, Nishanth Menon wrote:
>>>>> On 19:36-20200901, Kishon Vijay Abraham I wrote:
>>>>>> Add PCIe device tree node (both RC and EP) for the four
>>>>>> PCIe instances here.
>>>>>>
>>>>>> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
>>>>>> ---
>>>>>>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218
>>>>>> ++++++++++++++++++++++
>>>>>>   arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +-
>>>>>>   2 files changed, 222 insertions(+), 1 deletion(-)
>>>>>
>>>>>
>>>>> Did you look at the diff of the dtbs_check before and after this
>>>>> series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/
>>>>
>>>> I didn't see any errors when I checked for individual bindings
>>>> a0393678@...93678-ssd:~/repos/linux$ mkconfig64 dtbs_check
>>>> DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml"
>>>>
>>>>    SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml
>>>>    DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
>>>>    DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
>>>>    CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
>>>>    CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
>>>> a0393678@...93678-ssd:~/repos/linux$ mkconfig64 dtbs_check
>>>> DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml"
>>>>
>>>>    SCHEMA  Documentation/devicetree/bindings/processed-schema.yamlsimple-bus
>>>>    DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
>>>>    DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
>>>>    CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
>>>>    CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
>>>
>>> Can you give hint on why I get ranges is too long error
>>> https://pastebin.ubuntu.com/p/cPm2tg3dcV/ which I give mkconfig64
>>> dtbs_check but don't see an error when I include "DT_SCHEMA_FILES"?
>>
>> I debugged this and looks like PCIe "ranges" property conflicts with
>> simple-bus.
>>
>> A diff like below helps to solve the issue
>> diff --git a/schemas/simple-bus.yaml b/schemas/simple-bus.yaml
>> index 248ac9d..ed818ef 100644
>> --- a/schemas/simple-bus.yaml
>> +++ b/schemas/simple-bus.yaml
>> @@ -39,7 +39,7 @@ patternProperties:
>>          oneOf:
>>            - items:
>>                minItems: 3
>> -              maxItems: 6
>> +              maxItems: 7
>>              minItems: 0
>>              maxItems: 1024
>>            - $ref: "types.yaml#/definitions/flag"
>>
>> If this looks right to you, I can post a patch for it. Without fixing
>> this we would see false errors for PCIe DT nodes.
> 
> https://github.com/devicetree-org/dt-schema/commit/3baf308b01786788e3ccb9824fce6d7136b21214
> 
> Part of v2020.08.1? Am i missing something?

I think I was using a different repo
https://github.com/robherring/dt-schema.git.

Do you see the following issues you reported earlier with v2020.08.1?

+/home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@...000: pcie@...0000:ranges: [[16777216, 0, 268439552, 0, 268439552,
0, 65536], [33554432, 0, 268505088, 0, 268505088, 0, 134148096]] is not
valid under any of the given schemas (Possible causes of the failure):
+
/home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@...000: pcie@...0000:ranges: True was expected
+
/home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@...000: pcie@...0000:ranges:0: [16777216, 0, 268439552, 0,
268439552, 0, 65536] is too long
+
/home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@...000: pcie@...0000:ranges:1: [33554432, 0, 268505088, 0,
268505088, 0, 134148096] is too long
+

Thanks
Kishon
>