linux-kernel - Re: [PATCH][next] misc: hisi_hikey_usb: fix return of uninitialized ret status variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200914161332.2796e7b1@coco.lan>
Date:   Mon, 14 Sep 2020 16:13:32 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     John Stultz <john.stultz@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] misc: hisi_hikey_usb: fix return of uninitialized
 ret status variable

Em Mon, 14 Sep 2020 14:56:46 +0100
Colin King <colin.king@...onical.com> escreveu:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently the return value from ret is uninitialized so the function
> hisi_hikey_usb_parse_kirin970 is returning a garbage value when
> succeeding. Since ret is not used anywhere else in the function, remove
> it and just return 0 success at the end of the function.
> 
> Addresses-Coverity: ("Uninitialixed scalar variable")
> Fixes: d210a0023590 ("misc: hisi_hikey_usb: add support for Hikey 970")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

> ---
>  drivers/misc/hisi_hikey_usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/hisi_hikey_usb.c b/drivers/misc/hisi_hikey_usb.c
> index 2ddd4072788d..5759e7209023 100644
> --- a/drivers/misc/hisi_hikey_usb.c
> +++ b/drivers/misc/hisi_hikey_usb.c
> @@ -151,7 +151,6 @@ static int hisi_hikey_usb_parse_kirin970(struct platform_device *pdev,
>  					 struct hisi_hikey_usb *hisi_hikey_usb)
>  {
>  	struct regulator *regulator;
> -	int ret;
>  
>  	regulator = devm_regulator_get(&pdev->dev, "hub-vdd");
>  	if (IS_ERR(regulator)) {
> @@ -172,7 +171,7 @@ static int hisi_hikey_usb_parse_kirin970(struct platform_device *pdev,
>  	if (IS_ERR(hisi_hikey_usb->reset))
>  		return PTR_ERR(hisi_hikey_usb->reset);
>  
> -	return ret;
> +	return 0;
>  }
>  
>  static int hisi_hikey_usb_probe(struct platform_device *pdev)



Thanks,
Mauro