linux-kernel - Re: xconfig is broken again on Qt5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQ6M+9CSwEOb687jGQbtOX6GjKhQ3m45U7XrPs4_CJU0Q@mail.gmail.com>
Date:   Tue, 15 Sep 2020 00:25:07 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Maxim Levitsky <mlevitsk@...hat.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: xconfig is broken again on Qt5

On Sun, Sep 13, 2020 at 10:21 PM Maxim Levitsky <mlevitsk@...hat.com> wrote:
>
> I hate to say it, but xconfig got broken again.
>
> After commit 68fd110b3e7e2 ("kconfig: qconf: remove redundant help in the info view")
> help description disappered completely from xconfig (both normal and split mode)
>
> I reverted this and next commit to get this back.
>
> I have a feeling that there were several bugs introduced to xconfig recently
> due to attempt to support both Qt4 and Qt5. Maybe we should only support one version?

xconfig was originally written for Qt3, and
got broken in many ways after being converted to Qt5.
(commit 8328447af88eaab1d thru b4ff1de3b8381a4)

That is my gut feeling.

So, xconfig carried broken code everywhere
for many years.

I think supporting both Qt4 and Qt5
is doable, but testing both versions is tedious.
I'd like to want to drop Qt4 support in the future but
not in this development cycle because there are still
some people using Qt4.

Recently I changed xconfig a lot because I noticed
various bugs, and also needed to simplify the code
for better maintainability.

Sorry for the pain, but we need to change the code
to make it stable and maintainable.

For the reported issue,
does this work for you?
https://patchwork.kernel.org/patch/11774055/

> I tried gconfig even thinking maybe nobody uses xconfig these days
> but gconfig seems to lack search function.

gconfig is not well maintained either.

I think it should be converted from gtk+2 to gtk+3
and I know various bugs that need fixing
(but I have not been able to find time to work on it...)

> Best regards,
>         Maxim Levitsky
>

-- 
Best Regards
Masahiro Yamada