lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Sep 2020 17:44:30 +0200 From: Joerg Roedel <jroedel@...e.de> To: Vitaly Kuznetsov <vkuznets@...hat.com> Cc: x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, Borislav Petkov <bp@...en8.de>, Paolo Bonzini <pbonzini@...hat.com>, Sean Christopherson <sean.j.christopherson@...el.com>, Wanpeng Li <wanpengli@...cent.com>, Jim Mattson <jmattson@...gle.com>, Dan Carpenter <dan.carpenter@...cle.com>, Colin King <colin.king@...onical.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com> Subject: Re: [PATCH tip] KVM: nSVM: avoid freeing uninitialized pointers in svm_set_nested_state() On Mon, Sep 14, 2020 at 03:37:25PM +0200, Vitaly Kuznetsov wrote: > The save and ctl pointers are passed uninitialized to kfree() when > svm_set_nested_state() follows the 'goto out_set_gif' path. While > the issue could've been fixed by initializing these on-stack varialbles > to NULL, it seems preferable to eliminate 'out_set_gif' label completely > as it is not actually a failure path and duplicating a single svm_set_gif() > call doesn't look too bad. > > Fixes: 6ccbd29ade0d ("KVM: SVM: nested: Don't allocate VMCB structures on stack") > Addresses-Coverity: ("Uninitialized pointer read") > Reported-by: Dan Carpenter <dan.carpenter@...cle.com> > Reported-by: Joerg Roedel <jroedel@...e.de> > Reported-by: Colin King <colin.king@...onical.com> > Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com> Acked-by: Joerg Roedel <jroedel@...e.de>
Powered by blists - more mailing lists