linux-kernel - Re: [PATCH 05/15] habanalabs/gaudi: add NIC Ethernet support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200914094726.1c5f747c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 14 Sep 2020 09:47:26 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Omer Shpigelman <oshpigelman@...ana.ai>
Cc:     Oded Gabbay <oded.gabbay@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        SW_Drivers <SW_Drivers@...ana.ai>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH 05/15] habanalabs/gaudi: add NIC Ethernet support

On Mon, 14 Sep 2020 09:52:00 +0000 Omer Shpigelman wrote:
> On Thu, Sep 10, 2020 at 11:03 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > On Thu, 10 Sep 2020 19:11:16 +0300 Oded Gabbay wrote:  
> > > +module_param(nic_rx_poll, int, 0444);  
> > MODULE_PARM_DESC(nic_rx_poll,  
> > > +	"Enable NIC Rx polling mode (0 = no, 1 = yes, default no)");  
> > 
> > If your chip does not support IRQ coalescing you can configure polling and the
> > timeout via ethtool -C, rather than a module parameter.  
> 
> I couldn't find an example for that in other drivers and I didn't see
> anything regarding polling mode in the parameters description of this
> ethtool callback.
> Can you please specify some pointer for that? Or in other words, what
> parameter can we use to enable polling/setting the timeout?

Look at stmmac, hip04_eth..