linux-kernel - Re: [PATCH v2 1/3] dt-bindings: tlv320adcx140: Add GPIO config and drive config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ae63976-1e78-df28-9c76-d8f74c733eec@ti.com>
Date:   Tue, 15 Sep 2020 13:35:04 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Camel Guo <camel.guo@...s.com>, <lgirdwood@...il.com>,
        <broonie@...nel.org>, <tiwai@...e.com>
CC:     <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...s.com>, Camel Guo <camelg@...s.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: tlv320adcx140: Add GPIO config and
 drive config

Camel

On 9/11/20 3:07 AM, Camel Guo wrote:
> From: Camel Guo <camelg@...s.com>
>
> Add properties for configuring the General Purpose Input Outputs (GPIO).

s/Outputs/Output

There is only one for the x140

> There are 2 settings for GPIO, configuration and the output drive type.
>
> Signed-off-by: Camel Guo <camelg@...s.com>
> ---
>   .../bindings/sound/tlv320adcx140.yaml         | 44 +++++++++++++++++++
>   1 file changed, 44 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml b/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml
> index f578f17f3e04..7b0b4554da59 100644
> --- a/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml
> +++ b/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml
> @@ -134,6 +134,49 @@ patternProperties:
>          4d - Drive weak low and active high
>          5d - Drive Hi-Z and active high
>   
> +  ti,gpio-config:
> +    description: |
> +       Defines the configuration and output driver for the general purpose

s/driver/drive

You capitalized the General Purpose Input and Output in the commit 
message but kept it lower case here.

Beyond these

Acked-by: Dan Murphy <dmurphy@...com>