linux-kernel - Re: [PATCH v2 1/2] KVM: VMX: Move IRQ invocation to assembly subroutine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200915192705.vadb4he5obu3vdzm@treble>
Date:   Tue, 15 Sep 2020 14:27:05 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Uros Bizjak <ubizjak@...il.com>,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH v2 1/2] KVM: VMX: Move IRQ invocation to assembly
 subroutine

On Tue, Sep 15, 2020 at 12:15:04PM -0700, Sean Christopherson wrote:
> Move the asm blob that invokes the appropriate IRQ handler after VM-Exit
> into a proper subroutine.  Unconditionally create a stack frame in the
> subroutine so that, as objtool sees things, the function has standard
> stack behavior.  The dynamic stack adjustment makes using unwind hints
> problematic.
> 
> Suggested-by: Josh Poimboeuf <jpoimboe@...hat.com>
> Cc: Uros Bizjak <ubizjak@...il.com>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com>

Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>

-- 
Josh