[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200915165958.GA2118432@bogus>
Date: Tue, 15 Sep 2020 10:59:58 -0600
From: Rob Herring <robh@...nel.org>
To: Srinivasa Rao Mandadapu <srivasam@...eaurora.org>
Cc: agross@...nel.org, bjorn.andersson@...aro.org, lgirdwood@...il.com,
broonie@...nel.org, plai@...eaurora.org, bgoswami@...eaurora.org,
perex@...ex.cz, tiwai@...e.com, srinivas.kandagatla@...aro.org,
rohitkr@...eaurora.org, linux-arm-msm@...r.kernel.org,
alsa-devel@...a-project.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
V Sujith Kumar Reddy <vsujithk@...eaurora.org>
Subject: Re: [PATCH v4 2/5] ASoC: dt-bindings: Add dt binding for lpass hdmi
On Tue, Sep 08, 2020 at 05:44:39PM +0000, Srinivasa Rao Mandadapu wrote:
> From: V Sujith Kumar Reddy <vsujithk@...eaurora.org>
>
> Adds bindings for lpass hdmi interface
> which can support audio path over dp.
>
> Signed-off-by: Srinivasa Rao <srivasam@...eaurora.org>
> Signed-off-by: V Sujith Kumar Reddy <vsujithk@...eaurora.org>
> ---
> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 51 ++++++++++++++++++++--
> 1 file changed, 47 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> index 09c9bd2..7c2ac0c 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> @@ -22,6 +22,7 @@ properties:
> - qcom,lpass-cpu
> - qcom,apq8016-lpass-cpu
> - qcom,sc7180-lpass-cpu
> + - qcom,sc7180-lpass-hdmi
>
> reg:
> maxItems: 1
> @@ -60,10 +61,12 @@ properties:
> const: 0
>
> patternProperties:
> - "(^mi2s-[0-9a-f]$|mi2s)":
> + "^dai@[0-9a-f]$":
> type: object
> - description: Required properties for each DAI
> -
> + description: |
> + LPASS CPU dai node for each I2S device. Bindings of each node
> + depends on the specific driver providing the functionality and
> + properties.
> properties:
> reg:
> maxItems: 1
> @@ -145,6 +148,22 @@ allOf:
> - iommus
> - power-domains
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,sc7180-lpass-hdmi
> + then:
> + properties:
> + clock-names:
> + items:
> + - const: pcnoc-sway-clk
> + - const: audio-core
> + - const: pcnoc-mport-clk
> + required:
> + - iommus
> + - power-domains
> +
> examples:
> - |
> #include <dt-bindings/sound/sc7180-lpass.h>
> @@ -178,12 +197,36 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
> /* Optional to set different MI2S SD lines */
> - mi2s-primary@0 {
> + dai@...s-primary {
The unit address should be a number.
As this is not failing checks, then you are missing an
'additionalProperties: false'.
> reg = <MI2S_PRIMARY>;
> qcom,playback-sd-lines = <1>;
> qcom,capture-sd-lines = <0>;
> };
> };
> +
> + lpassh@...87000 {
> + compatible = "qcom,sc7180-lpass-hdmi";
> +
> + reg = <0 0x62d87000 0 0x68000>;
> +
> + iommus = <&apps_smmu 0x1032 0>;
> +
> + power-domains = <&lpass_hm 0>;
> +
> + clocks = <&gcc 131>,
> + <&lpasscc 6>,
> + <&lpasscc 10>;
> +
> + clock-names = "pcnoc-sway-clk", "audio-core",
> + "pcnoc-mport-clk";
> +
> + #sound-dai-cells = <1>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + interrupts = <0 268 1>;
> + };
> };
>
> ...
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
> is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
>
Powered by blists - more mailing lists