linux-kernel - Re: [PATCH 09/26] perf tools: Try load vmlinux from buildid database

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cgOnwR9qRiJhf8kz0YGphVNyoBCXHuAtc-dSNtoUMeasA@mail.gmail.com>
Date:   Tue, 15 Sep 2020 11:58:16 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Michael Petlan <mpetlan@...hat.com>,
        Song Liu <songliubraving@...com>,
        "Frank Ch. Eigler" <fche@...hat.com>,
        Ian Rogers <irogers@...gle.com>,
        Stephane Eranian <eranian@...gle.com>,
        Alexey Budankov <alexey.budankov@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 09/26] perf tools: Try load vmlinux from buildid database

On Tue, Sep 15, 2020 at 5:29 AM Jiri Olsa <jolsa@...hat.com> wrote:
>
> On Mon, Sep 14, 2020 at 03:25:39PM +0900, Namhyung Kim wrote:
> > On Mon, Sep 14, 2020 at 6:04 AM Jiri Olsa <jolsa@...nel.org> wrote:
> > >
> > > Currently we don't check on kernel's vmlinux the same way as
> > > we do for normal binaries, but we either look for kallsyms
> > > file in build id database or check on known vmlinux locations
> > > (plus some other optional paths).
> > >
> > > This patch adds the check for standard build id binary location,
> > > so we are ready once we start to store it there from debuginfod
> > > in following changes.
> >
> > But dso__load_vmlinux_path() already has the logic.
> > Also you should check symbol_conf.ignore_vmlinux_buildid.
>
> I wanted to have it not dependent on !symbol_conf.ignore_vmlinux
> which is needed to call dso__load_vmlinux_path

Note that it's a different config variable to suppress using build-id
when loading kernel DSO from perf record.

Thanks
Namhyung

>
> also the idea was to try the build id vmlinux before the configured
> vmlinux locations, because they found the vmlinux in my setup ;-)
>
> I'll double check the logic again
>
> thanks,
> jirka
>