linux-kernel - Re: [PATCH -next] usbip: simplify the return expression of usbip_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81ff1561-ab22-905c-7fd1-424814e96c41@linuxfoundation.org>
Date:   Tue, 15 Sep 2020 10:37:48 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Liu Shixin <liushixin2@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Valentina Manea <valentina.manea.m@...il.com>,
        Shuah Khan <shuah@...nel.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH -next] usbip: simplify the return expression of
 usbip_core_init()

On 9/14/20 9:26 PM, Liu Shixin wrote:
> Simplify the return expression.
> 
> Signed-off-by: Liu Shixin <liushixin2@...wei.com>
> ---
>   drivers/usb/usbip/usbip_common.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c
> index e4b96674c405..4ce6c6a45eb1 100644
> --- a/drivers/usb/usbip/usbip_common.c
> +++ b/drivers/usb/usbip/usbip_common.c
> @@ -755,13 +755,7 @@ EXPORT_SYMBOL_GPL(usbip_recv_xbuff);
>   
>   static int __init usbip_core_init(void)
>   {
> -	int ret;
> -
> -	ret = usbip_init_eh();
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return usbip_init_eh();
>   }
>   
>   static void __exit usbip_core_exit(void)
> 

Looks good to me.

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah