linux-kernel - Re: [PATCH v3 0/6] kasan: add workqueue and timer stack for generic KASAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 16 Sep 2020 00:06:41 +0800
From:   Walter Wu <walter-zh.wu@...iatek.com>
To:     Andrey Konovalov <andreyknvl@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>
CC:     Marco Elver <elver@...gle.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        John Stultz <john.stultz@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Tejun Heo <tj@...nel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        kasan-dev <kasan-dev@...glegroups.com>,
        "Linux Memory Management List" <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        wsd_upstream <wsd_upstream@...iatek.com>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v3 0/6] kasan: add workqueue and timer stack for generic
 KASAN

On Mon, 2020-09-14 at 14:25 +0200, Andrey Konovalov wrote:
> On Sun, Sep 13, 2020 at 12:17 PM Dmitry Vyukov <dvyukov@...gle.com>
> wrote:
> 
>         On Wed, Aug 26, 2020 at 2:30 PM 'Andrey Konovalov' via
>         kasan-dev
>         <kasan-dev@...glegroups.com> wrote:
>         >
>         > On Tue, Aug 25, 2020 at 10:26 AM 'Marco Elver' via kasan-dev
>         > <kasan-dev@...glegroups.com> wrote:
>         > >
>         > > On Tue, 25 Aug 2020 at 03:57, Walter Wu
>         <walter-zh.wu@...iatek.com> wrote:
>         > > >
>         > > > Syzbot reports many UAF issues for workqueue or timer,
>         see [1] and [2].
>         > > > In some of these access/allocation happened in
>         process_one_work(),
>         > > > we see the free stack is useless in KASAN report, it
>         doesn't help
>         > > > programmers to solve UAF on workqueue. The same may
>         stand for times.
>         > > >
>         > > > This patchset improves KASAN reports by making them to
>         have workqueue
>         > > > queueing stack and timer stack information. It is useful
>         for programmers
>         > > > to solve use-after-free or double-free memory issue.
>         > > >
>         > > > Generic KASAN also records the last two workqueue and
>         timer stacks and
>         > > > prints them in KASAN report. It is only suitable for
>         generic KASAN.
>         > > >
>         > > > [1]https://groups.google.com/g/syzkaller-bugs/search?q=%
>         22use-after-free%22+process_one_work
>         > > > [2]https://groups.google.com/g/syzkaller-bugs/search?q=%
>         22use-after-free%22%20expire_timers
>         > > > [3]https://bugzilla.kernel.org/show_bug.cgi?id=198437
>         > > >
>         > > > Walter Wu (6):
>         > > > timer: kasan: record timer stack
>         > > > workqueue: kasan: record workqueue stack
>         > > > kasan: print timer and workqueue stack
>         > > > lib/test_kasan.c: add timer test case
>         > > > lib/test_kasan.c: add workqueue test case
>         > > > kasan: update documentation for generic kasan
>         > >
>         > > Acked-by: Marco Elver <elver@...gle.com>
>         >
>         > Reviewed-by: Andrey Konovalov <andreyknvl@...gle.com>
>         
>         Reviewed-by: Dmitry Vyukov <dvyukov@...gle.com>
>         
>         Thanks! The UAF reports with RCU stacks that I see now are
>         just 🔥🔥🔥
> 
> 
> Hi Walter,
> 
> 
> This patchset needs to be rebased onto the KASAN-KUNIT patches, which
> just recently went into the mm tree.
> 
> 
> Thanks!

Hi Dmitry, Andrey,

Got it. 

Thanks for your review and reminder.

Walter