linux-kernel - Re: [PATCH 0/6] Add support for MCP25XXFD SPI-CAN Network driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200915161925.GA5660@linux>
Date:   Tue, 15 Sep 2020 21:49:25 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     wg@...ndegger.com, mkl@...gutronix.de, robh+dt@...nel.org
Cc:     linux-can@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, dev.kurt@...dijck-laurijssen.be,
        o.rempel@...gutronix.de
Subject: Re: [PATCH 0/6] Add support for MCP25XXFD SPI-CAN Network driver

Hi,

On Thu, Sep 10, 2020 at 07:08:00PM +0530, Manivannan Sadhasivam wrote:
> Hello,
> 
> This series is the continuation of the work done by Marc Kleine-Budde on
> adding support for Microchip MCP25XXFD SPI-CAN driver [1]. I've taken the
> patches from Marc's tree [2] and posted with an additional MAINTAINERS
> patch on top since he seems to be very busy. This series has been tested
> on RB5 board featuring MCP2518FD transceiver.
> 
> Marc: I'd like to co-maintain this driver in upstream hence added myself
> as the co-maintainer. Shout at me if you do not want it! Also I've removed
> the v4x tag since I don't think all the versions are posted to mailing
> list.
> 
> I'll add my review on top of this posting.
> 

Just a quick question: I don't see any activity on this specific driver for
sometime (back in Martin days itself). Is it due to lack of reviewers or
it is due to the patch size (lines of code) so that nobody is interested
in reviewing?

How are we going to move forward?

Thanks,
Mani

> Thanks,
> Mani
> 
> [1] https://www.spinics.net/lists/linux-can/msg03712.html
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=mcp25xxfd-47
> 
> Kurt Van Dijck (1):
>   can: mcp25xxfd: add listen-only mode
> 
> Manivannan Sadhasivam (1):
>   MAINTAINERS: Add entry for Microchip MCP25XXFD SPI-CAN network driver
> 
> Marc Kleine-Budde (3):
>   can: rx-offload: can_rx_offload_add_manual(): add new initialization
>     function
>   can: mcp25xxfd: add regmap infrastructure
>   can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN
> 
> Oleksij Rempel (1):
>   dt-bindings: can: mcp25xxfd: document device tree bindings
> 
>  .../bindings/net/can/microchip,mcp25xxfd.yaml |   79 +
>  MAINTAINERS                                   |    8 +
>  drivers/net/can/rx-offload.c                  |   11 +
>  drivers/net/can/spi/Kconfig                   |    2 +
>  drivers/net/can/spi/Makefile                  |    1 +
>  drivers/net/can/spi/mcp25xxfd/Kconfig         |   17 +
>  drivers/net/can/spi/mcp25xxfd/Makefile        |    8 +
>  .../net/can/spi/mcp25xxfd/mcp25xxfd-core.c    | 2884 +++++++++++++++++
>  .../net/can/spi/mcp25xxfd/mcp25xxfd-crc16.c   |   89 +
>  .../net/can/spi/mcp25xxfd/mcp25xxfd-regmap.c  |  556 ++++
>  drivers/net/can/spi/mcp25xxfd/mcp25xxfd.h     |  828 +++++
>  include/linux/can/rx-offload.h                |    3 +
>  12 files changed, 4486 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.yaml
>  create mode 100644 drivers/net/can/spi/mcp25xxfd/Kconfig
>  create mode 100644 drivers/net/can/spi/mcp25xxfd/Makefile
>  create mode 100644 drivers/net/can/spi/mcp25xxfd/mcp25xxfd-core.c
>  create mode 100644 drivers/net/can/spi/mcp25xxfd/mcp25xxfd-crc16.c
>  create mode 100644 drivers/net/can/spi/mcp25xxfd/mcp25xxfd-regmap.c
>  create mode 100644 drivers/net/can/spi/mcp25xxfd/mcp25xxfd.h
> 
> -- 
> 2.17.1
>