linux-kernel - Re: [PATCH 3/3] i2c: jz4780: Remove of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Sep 2020 18:07:26 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Rob Herring <robh@...nel.org>
Cc:     od@...c.me, Linux I2C <linux-i2c@...r.kernel.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()



Le mar. 15 sept. 2020 à 10:03, Rob Herring <robh@...nel.org> a écrit :
> On Tue, Sep 15, 2020 at 4:07 AM Paul Cercueil <paul@...pouillou.net> 
> wrote:
>> 
>>  Hi Rob,
>> 
>>  Le lun. 14 sept. 2020 à 16:12, Rob Herring <robh@...nel.org> a 
>> écrit :
>>  > On Fri, Sep 04, 2020 at 03:11:52PM +0200, Paul Cercueil wrote:
>>  >>  CONFIG_OF is selected by CONFIG_MACH_INGENIC, therefore we don't
>>  >> need to
>>  >>  handle the case where Device Tree is not supported.
>>  >
>>  > What about COMPILE_TEST? If not supported, why not?
>> 
>>  What about it? It will still compile fine with COMPILE_TEST.
> 
> CONFIG_OF could be disabled in that case, so the above reasoning 
> doesn't hold.
> 

CONFIG_OF can be disabled in that case, correct, but why should we 
care? The driver will still compile fine.

-Paul