linux-kernel - Re: [PATCH] platform/chrome: cros_ec_debugfs: Support pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACeCKacudCkMoT40UJaf8PKUQu9G0csBmhih8cBO2Y3TAhV-0Q@mail.gmail.com>
Date:   Tue, 15 Sep 2020 08:34:41 -0700
From:   Prashant Malani <pmalani@...omium.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     Stephen Boyd <swboyd@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_debugfs: Support pd_info v2 format

HI Enric,

On Tue, Sep 15, 2020 at 5:48 AM Enric Balletbo i Serra
<enric.balletbo@...labora.com> wrote:
>
> Hi Stephen, Prashant,
>
> On 9/9/20 6:04, Stephen Boyd wrote:
> > Let's try to read more information out of more modern cros_ec devices by
> > using the v2 format first and then fall back to the v1 format. This
> > gives us more information about things such as DP mode of the typec pins
> > and the CC state, along with some more things.
> >
> > Cc: Gwendal Grignou <gwendal@...omium.org>
> > Cc: Prashant Malani <pmalani@...omium.org>
> > Cc: Guenter Roeck <groeck@...omium.org>
> > Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> > ---
> >
>
> I saw some discussion going on in gerrit (a pity the discussion didn't happen in
> mainline) Did you end with a conclusion? Can I remove this patch from my backlog?

My apologies for not posting the comment here.
To summarize: the userspace EC utility ectool [1] can offer the
equivalent output, but with better formatting. So I believe the
decision is to use that instead of this patch.
I also posed a counter-question: can we remove this debugfs pdinfo
file entirely, since we can pull this information using ectool?

[1]: https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/master/util/ectool.c

Best regards,