linux-kernel - Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200915145533.GG3736@dhcp22.suse.cz>
Date:   Tue, 15 Sep 2020 16:55:33 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     Chris Down <chris@...isdown.name>
Cc:     zangchunxin@...edance.com, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Muchun Song <songmuchun@...edance.com>
Subject: Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node

On Tue 15-09-20 15:47:37, Chris Down wrote:
> zangchunxin@...edance.com writes:
> > +		if (signal_pending(current))
> > +			return;
> 
> This doesn't match your patch title, please update it. :-)

I have to admit I have completely missed this and I think that this
should better be fatal_signal_pending because that would make sure that
the userspace will not see an incomplete operation. This is a general
practice for other bail outs as well.

> After that, you can add:
> 
> Acked-by: Chris Down <chris@...isdown.name>

-- 
Michal Hocko
SUSE Labs