linux-kernel - Re: [PATCH] dt-bindings: net: Correct interrupt flags in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <101d6fb4-4b4f-feb1-dc66-410d3f0b00c5@pengutronix.de>
Date:   Tue, 15 Sep 2020 08:26:05 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Krzysztof Kozlowski <krzk@...nel.org>, Dan Murphy <dmurphy@...com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: net: Correct interrupt flags in examples

On 9/8/20 4:59 PM, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING
> 
> Correct the interrupt flags, assuming the author of the code wanted some
> logical behavior behind the name "ACTIVE_xxx", this is:
>   ACTIVE_LOW  => IRQ_TYPE_LEVEL_LOW
>   ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +-
>  Documentation/devicetree/bindings/net/nfc/nxp-nci.txt  | 2 +-
>  Documentation/devicetree/bindings/net/nfc/pn544.txt    | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> index 3613c2c8f75d..0968b40aef1e 100644
> --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> @@ -33,7 +33,7 @@ tcan4x5x: tcan4x5x@0 {
>  		spi-max-frequency = <10000000>;
>  		bosch,mram-cfg = <0x0 0 0 32 0 0 1 1>;
>  		interrupt-parent = <&gpio1>;
> -		interrupts = <14 GPIO_ACTIVE_LOW>;
> +		interrupts = <14 IRQ_TYPE_LEVEL_LOW>;
>  		device-state-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;
>  		device-wake-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
>  		reset-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;

For the tcan4x5x.txt:

Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)