linux-kernel - Re: [PATCH] memory: omap-gpmc: Fix compile test on SPARC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6163cc96-3f91-893d-3c1c-555ed9ee4b82@ti.com>
Date:   Tue, 15 Sep 2020 10:46:28 +0300
From:   Roger Quadros <rogerq@...com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
CC:     Tony Lindgren <tony@...mide.com>, <linux-omap@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] memory: omap-gpmc: Fix compile test on SPARC



On 11/09/2020 17:55, Krzysztof Kozlowski wrote:
> On Fri, 11 Sep 2020 at 16:48, Roger Quadros <rogerq@...com> wrote:
>>
>> Hi Krzysztof,
>>
>> On 11/09/2020 17:32, Krzysztof Kozlowski wrote:
>>> SPARC comes without CONFIG_OF_ADDRESS thus compile testing fails on
>>> linking:
>>>
>>>     /usr/bin/sparc64-linux-gnu-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child':
>>>     omap-gpmc.c:(.text.unlikely+0x14ec): undefined reference to `of_platform_device_create'
>>>
>>> Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
>>> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>>> ---
>>>    drivers/memory/Kconfig | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
>>> index 8072204bc21a..00e013b14703 100644
>>> --- a/drivers/memory/Kconfig
>>> +++ b/drivers/memory/Kconfig
>>> @@ -104,6 +104,7 @@ config TI_EMIF
>>>
>>>    config OMAP_GPMC
>>>        bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
>>> +     depends on OF_ADDRESS
>>
>> but of_platform_device_create() is defined in platform.c which gets built
>> irrespective of OF_ADDRESS.
>>
>> Maybe we need to just depend on CONFIG_OF ?
> 
> No, the of_platform_device_create() is defined there within #ifdef
> CONFIG_OF_ADDRESS
> 
> The CONFIG_OF was already selected and was not enough.
> 
> Other solution is "depends on !SPARC"...
> 

OK. In that case this patch is better.

cheers,
-roger
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki