linux-kernel - Re: [PATCH v12 00/14] mtd: spi-nor: add xSPI Octal DTR support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200915074727.o4drgfgdabhozjb5@ti.com>
Date:   Tue, 15 Sep 2020 13:17:29 +0530
From:   Pratyush Yadav <p.yadav@...com>
To:     Vignesh Raghavendra <vigneshr@...com>
CC:     Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        "open list:SPI NOR SUBSYSTEM" <linux-mtd@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>,
        Sekhar Nori <nsekhar@...com>,
        Boris Brezillon <boris.brezillon@...labora.com>
Subject: Re: [PATCH v12 00/14] mtd: spi-nor: add xSPI Octal DTR support

On 15/09/20 12:16PM, Vignesh Raghavendra wrote:
> 
> 
> On 9/3/20 10:42 PM, Pratyush Yadav wrote:
> > Hi,
> > 
> > This series adds support for Octal DTR flashes in the SPI NOR framework,
> > and then adds hooks for the Cypress Semper and Micron Xcella flashes to
> > allow running them in Octal DTR mode. This series assumes that the flash
> > is handed to the kernel in Legacy SPI mode.
> > 
> > Tested on TI J721E EVM with 1-bit ECC on the Cypress flash.
> > 
> [...]
> 
> Please fix checkpatch issues on patch 1, 3, 4 and 5

I ran checkpatch on my patches based on top of next-20200914 just now. I 
only see issues with patches 3 and 4. Patches 1 and 5 report no issues. 
What problems do you see on patches 1 and 5?

As for patches 3 and 4, the error I see is "ENOTSUPP is not a SUSV4 
error code, prefer EOPNOTSUPP". I left it in intentionally. There a 
couple other functions in SPI NOR that use ENOTSUPP instead of 
EOPNOTSUPP so I followed the local convention.

If you insist, I can add a preparatory patch that first changes those 
uses of ENOTSUPP to EOPNOTSUPP and then update patches 3 and 4 to do the 
same. Let me know.

> Otherwise patches look good to me...

Thanks.

-- 
Regards,
Pratyush Yadav
Texas Instruments India