linux-kernel - Re: [PATCH] fork: Use helper function mapping_allow_writable() in dup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <df8ee8e7e0ce4a78bd0b6e3599149592@huawei.com>
Date:   Tue, 15 Sep 2020 09:25:36 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
CC:     "christian.brauner@...ntu.com" <christian.brauner@...ntu.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "christian@...lner.me" <christian@...lner.me>,
        "surenb@...gle.com" <surenb@...gle.com>,
        "areber@...hat.com" <areber@...hat.com>,
        "shakeelb@...gle.com" <shakeelb@...gle.com>,
        "cyphar@...har.com" <cyphar@...har.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fork: Use helper function mapping_allow_writable() in
 dup_mmap()

Eric W. Biederman <ebiederm@...ssion.com> wrote:
> linmiaohe <linmiaohe@...wei.com> writes:
>> Eric W. Biederman <ebiederm@...ssion.com> wrote:
>>> Miaohe Lin <linmiaohe@...wei.com> writes:
>>>
>>>> Use helper function mapping_allow_writable() to atomic_inc 
>>>> i_mmap_writable.
>>>
>>>Why?
>>>
>>
>> Because I think it's better to use the wrapper function instead of the 
>> open hard code.
>
>My point is there is no context in this commit message.
>
>What makes it better to use the wrapper function?
>What makes the wrapper function the appropriate function to use?
>Why just this location?
>Why wasn't this change made when the wrapper function was introduced?
>
>I could probably read through the code and figure these things out but the description of the change should really include these things.
>
>Eric

I see. Many thanks for your detailed explaination. :)