linux-kernel - Re: [PATCH 3/3] i2c: jz4780: Remove of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Sep 2020 12:07:24 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Rob Herring <robh@...nel.org>
Cc:     od@...c.me, linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()

Hi Rob,

Le lun. 14 sept. 2020 à 16:12, Rob Herring <robh@...nel.org> a écrit :
> On Fri, Sep 04, 2020 at 03:11:52PM +0200, Paul Cercueil wrote:
>>  CONFIG_OF is selected by CONFIG_MACH_INGENIC, therefore we don't 
>> need to
>>  handle the case where Device Tree is not supported.
> 
> What about COMPILE_TEST? If not supported, why not?

What about it? It will still compile fine with COMPILE_TEST.

-Paul

>> 
>>  Signed-off-by: Paul Cercueil <paul@...pouillou.net>
>>  ---
>>   drivers/i2c/busses/i2c-jz4780.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>>  diff --git a/drivers/i2c/busses/i2c-jz4780.c 
>> b/drivers/i2c/busses/i2c-jz4780.c
>>  index ed2ec86f6f1a..cb4a25ebb890 100644
>>  --- a/drivers/i2c/busses/i2c-jz4780.c
>>  +++ b/drivers/i2c/busses/i2c-jz4780.c
>>  @@ -857,7 +857,7 @@ static struct platform_driver jz4780_i2c_driver 
>> = {
>>   	.remove		= jz4780_i2c_remove,
>>   	.driver		= {
>>   		.name	= "jz4780-i2c",
>>  -		.of_match_table = of_match_ptr(jz4780_i2c_of_matches),
>>  +		.of_match_table = jz4780_i2c_of_matches,
>>   	},
>>   };
>> 
>>  --
>>  2.28.0
>>