linux-kernel - RE: [EXT] Re: rtc: fsl-ftm-alarm: add shutdown interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB6PR0401MB24385907880BAA626E5909528F200@DB6PR0401MB2438.eurprd04.prod.outlook.com>
Date:   Tue, 15 Sep 2020 10:35:12 +0000
From:   Biwen Li <biwen.li@....com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "Biwen Li (OSS)" <biwen.li@....nxp.com>
CC:     Leo Li <leoyang.li@....com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jiafei Pan <jiafei.pan@....com>
Subject: RE: [EXT] Re: rtc: fsl-ftm-alarm: add shutdown interface

> 
> Hi,
> 
> On 30/03/2020 18:44:01+0200, Alexandre Belloni wrote:
> > On 30/03/2020 20:26:16+0800, Biwen Li wrote:
> > > From: Biwen Li <biwen.li@....com>
> > >
> > > Add shutdown interface
> > >
> > > Signed-off-by: Biwen Li <biwen.li@....com>
> > > ---
> > >  drivers/rtc/rtc-fsl-ftm-alarm.c | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > >
> > > diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > b/drivers/rtc/rtc-fsl-ftm-alarm.c index d7fa6c16f47b..118a775e8316
> > > 100644
> > > --- a/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > @@ -307,6 +307,15 @@ static int ftm_rtc_probe(struct platform_device
> *pdev)
> > >     return 0;
> > >  }
> > >
> > > +static void ftm_rtc_shutdown(struct platform_device *pdev) {
> > > +   struct ftm_rtc *rtc = platform_get_drvdata(pdev);
> > > +
> > > +   ftm_irq_acknowledge(rtc);
> > > +   ftm_irq_disable(rtc);
> > > +   ftm_clean_alarm(rtc);
> >
> > If the alarm is able to start the platform, then you probably don't
> > want to disable the alarm on shutdown.
> >
> 
> I realise you never replied to that question. Is that patch still of interest?
Hi Alex, you can drop it. Thanks.
Best Regards,
Biwen Li
> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
> om%2F&amp;data=02%7C01%7Cbiwen.li%40nxp.com%7Cd688030894714bca7
> 5c708d8596210ec%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 7357625013809281&amp;sdata=pOBMmsxi7DVlywuLZ2LOLVgK4r4GtvW1PYq1
> p9JVv74%3D&amp;reserved=0