linux-kernel - Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 15 Sep 2020 13:42:23 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     "sean@...s.org" <sean@...s.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

On Tue, Sep 15, 2020 at 11:06 AM Joakim Zhang <qiangqing.zhang@....com> wrote:
> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Sent: 2020年9月15日 15:18
> To: Joakim Zhang <qiangqing.zhang@....com>
> Cc: sean@...s.org; mchehab@...nel.org; linux-media@...r.kernel.org; linux-kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system
> On Tuesday, September 15, 2020, Joakim Zhang <qiangqing.zhang@....com> wrote:




> +       ret = pm_runtime_get(dev);
> +       if (ret < 0)
>
>
>
> Here is reference counter leak.
>
>
>
> Thanks Andy for your kindly review.
>
> pm_runtime_get increase the usage_count even it fails, so need call pm_runtime_put_noidle here to balance the usage_count. Am I right?

Yes.

> +               return IRQ_NONE;


-- 
With Best Regards,
Andy Shevchenko