linux-kernel - Re: [PATCH] IB/rxe: fix kconfig dependency warning for RDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200915105920.GA486552@unreal>
Date:   Tue, 15 Sep 2020 13:59:20 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Necip Fazil Yildiran <fazilyildiran@...il.com>
Cc:     dledford@...hat.com, jgg@...lanox.com, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, paul@...zz.com, jeho@...utexas.edu
Subject: Re: [PATCH] IB/rxe: fix kconfig dependency warning for RDMA_RXE

On Tue, Sep 15, 2020 at 01:16:00PM +0300, Necip Fazil Yildiran wrote:
> When RDMA_RXE is enabled and CRYPTO is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_CRC32
>   Depends on [n]: CRYPTO [=n]
>   Selected by [y]:
>   - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && (!64BIT || ARCH_DMA_ADDR_T_64BIT [=n])
>
> The reason is that RDMA_RXE selects CRYPTO_CRC32 without depending on or
> selecting CRYPTO while CRYPTO_CRC32 is subordinate to CRYPTO.

It is not RXE specific issue and almost all users of CRYPTO_* configs
don't select CRYPTO.

There are two possible solutions.
1. Fix crypto/Kconfig to enable CRYPTO.
2. Change "select CRYPTO_CRC32" to be "depends on CRYPTO_CRC32".

Thanks

>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: 0812ed132178 ("IB/rxe: Change RDMA_RXE kconfig to use select")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>
> ---
>  drivers/infiniband/sw/rxe/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig
> index a0c6c7dfc181..e1f52710edfc 100644
> --- a/drivers/infiniband/sw/rxe/Kconfig
> +++ b/drivers/infiniband/sw/rxe/Kconfig
> @@ -4,6 +4,7 @@ config RDMA_RXE
>  	depends on INET && PCI && INFINIBAND
>  	depends on !64BIT || ARCH_DMA_ADDR_T_64BIT
>  	select NET_UDP_TUNNEL
> +	select CRYPTO
>  	select CRYPTO_CRC32
>  	select DMA_VIRT_OPS
>  	help
> --
> 2.25.1
>