linux-kernel - Re: [PATCH v11 06/24] coresight: add try_get_module() in coresight_grab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12e78abe-f5e0-0016-8984-f16aed77c755@arm.com>
Date:   Tue, 15 Sep 2020 12:08:08 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     tingwei@...eaurora.org, mathieu.poirier@...aro.org,
        alexander.shishkin@...ux.intel.com, mike.leach@...aro.org
Cc:     gregkh@...uxfoundation.org, leo.yan@...aro.org,
        rdunlap@...radead.org, linux@...linux.org.uk, kim.phillips@....com,
        ykaukab@...e.de, tsoni@...eaurora.org,
        saiprakash.ranjan@...eaurora.org, jinlmao@...eaurora.org,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 06/24] coresight: add try_get_module() in
 coresight_grab_device()

On 09/15/2020 11:40 AM, Tingwei Zhang wrote:
> When coresight device is in an active session, driver module of
> that device should not be removed. Use try_get_module() in
> coresight_grab_device() to prevent module to be unloaded.
> Use get_device()/put_device() to protect device data
> in the middle of active session.
> 
> Signed-off-by: Tingwei Zhang <tingwei@...eaurora.org>
> Tested-by: Mike Leach <mike.leach@...aro.org>
> Suggested-by: Suzuki K Poulose <suzuki.poulose@....com>

Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>