[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d2ba619c-5d56-243b-7527-4c2efb6859ff@gmail.com>
Date: Tue, 15 Sep 2020 15:06:46 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: David Miller <davem@...emloft.net>, luojiaxing@...wei.com,
idos@...lanox.com, ogerlitz@...lanox.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to
ring_cons but not used it anymore in mlx4_en_xmit()
On 9/14/2020 11:02 PM, Jakub Kicinski wrote:
> On Sun, 13 Sep 2020 13:12:05 +0300 Tariq Toukan wrote:
>> 2. When MLX4_EN_PERF_STAT is not defined, we should totally remove the
>> local variable declaration, not only its usage.
>
> I was actually wondering about this when working on the pause stat
> patch. Where is MLX4_EN_PERF_STAT ever defined?
>
> $ git grep MLX4_EN_PERF_STAT
> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:#ifdef MLX4_EN_PERF_STAT
> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:#endif /* MLX4_EN_PERF_STAT */
> drivers/net/ethernet/mellanox/mlx4/mlx4_stats.h:#ifdef MLX4_EN_PERF_STAT
>
Good point.
This was introduced long ago, since day 1 of mlx4 driver.
I believe it had off-tree usage back then, not sure though...
Anyway, I don't find it useful anymore.
Should be removed. I'll prepare a cleanup patch for net-next.
Thanks,
Tariq
Powered by blists - more mailing lists