linux-kernel - Re: [PATCH] scsi: target: remove redundant assignment to variable 'ret'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Sep 2020 13:58:00 +0200
From:   Maurizio Lombardi <mlombard@...hat.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>,
        martin.petersen@...cle.com, bvanassche@....org,
        michael.christie@...cle.com, sudhakar.panneerselvam@...cle.com,
        ddiss@...e.de, gustavoars@...nel.org
Cc:     linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: target: remove redundant assignment to variable
 'ret'



Dne 14. 09. 20 v 4:32 Jing Xiangfeng napsal(a):
> The variable ret has been initialized with a value '0'. The assignment
> in switch-case is redundant. So remove it.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
> ---
>  drivers/target/iscsi/iscsi_target.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index cd045dc75a58..f5272ac18b16 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -4516,7 +4516,6 @@ int iscsit_logout_post_handler(
>  			iscsit_logout_post_handler_closesession(conn);
>  			break;
>  		}
> -		ret = 0;
>  		break;
>  	case ISCSI_LOGOUT_REASON_CLOSE_CONNECTION:
>  		if (conn->cid == cmd->logout_cid) {
> @@ -4527,7 +4526,6 @@ int iscsit_logout_post_handler(
>  				iscsit_logout_post_handler_samecid(conn);
>  				break;
>  			}
> -			ret = 0;
>  		} else {
>  			switch (cmd->logout_response) {
>  			case ISCSI_LOGOUT_SUCCESS:
> 

Looks ok to me.

Reviewed-by: Maurizio Lombardi <mlombard@...hat.com>