linux-kernel - Re: [PATCH] time: Avoid undefined behaviour in timespec64_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2WG0DvTyrTkiLg3GW1x2s-oo8BgAyvp7uHvzXhJCiHmQ@mail.gmail.com>
Date:   Tue, 15 Sep 2020 14:45:20 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     "Zengtao (B)" <prime.zeng@...ilicon.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] time: Avoid undefined behaviour in timespec64_to_ns

On Tue, Sep 15, 2020 at 2:20 PM Zengtao (B) <prime.zeng@...ilicon.com> wrote:

> > > Fixes: bd40a175769d ("y2038: itimer: change implementation to
> > timespec64")
> >
> > This one caused the regression, but if we add the check here, it
> > may be best to also add it in prior kernels that may have the same
> > bug in other callers of the same function. Maybe backport all the
> > way to stable kernels that first added timespec64?
> >
>
> I think we need to do the backport, but not sure about the start point
> Thanks for your review.

I would suggest

Cc: <stable@...r.kernel.org> # v3.17+
Fixes: 361a3bf00582 ("time64: Add time64.h header and define struct timespec64")

       Arnd