linux-kernel - Re: [PATCH] fork: Use helper function mapping_allow_writable() in dup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200915154704.lvboxqqgfokbhidc@wittgenstein>
Date:   Tue, 15 Sep 2020 17:47:04 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, peterz@...radead.org, mingo@...nel.org,
        ebiederm@...ssion.com, christian@...lner.me, surenb@...gle.com,
        areber@...hat.com, shakeelb@...gle.com, cyphar@...har.com,
        tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fork: Use helper function mapping_allow_writable() in
 dup_mmap()

On Sun, Sep 13, 2020 at 05:24:15AM -0400, Miaohe Lin wrote:
> Use helper function mapping_allow_writable() to atomic_inc i_mmap_writable.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---

Hey Miaohe,

Thanks for the patch!
Per se there's nothing against using a proper helper when it exists.
But it has already been pointed out that this needs a proper commit
message with more rationale. But I'm otherwise happy to take this.

Thanks!
Christian