linux-kernel - Re: [RFC 03/10] phy: hisilicon: phy-hi3670-usb3: use a consistent namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqK35cNgibV6ajQABCAMsPe+BvL1nOU51XPW-sdfVMgqDA@mail.gmail.com>
Date:   Tue, 15 Sep 2020 10:51:59 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Linuxarm <linuxarm@...wei.com>, mauro.chehab@...wei.com,
        John Stultz <john.stultz@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>, Yu Chen <chenyu56@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org
Subject: Re: [RFC 03/10] phy: hisilicon: phy-hi3670-usb3: use a consistent namespace

On Wed, Sep 9, 2020 at 11:37 PM Mauro Carvalho Chehab
<mchehab+huawei@...nel.org> wrote:
>
> Em Wed, 9 Sep 2020 14:15:59 -0600
> Rob Herring <robh+dt@...nel.org> escreveu:
>
> > On Fri, Sep 4, 2020 at 4:23 AM Mauro Carvalho Chehab
> > <mchehab+huawei@...nel.org> wrote:
> > >
> > > Rename hikey970 to hi3670, in order to use a namespace
> > > similar to hi3660 driver.
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > > ---
> > >  .../bindings/phy/phy-hi3670-usb3.txt          |  4 +-
> >
> > Bindings should be a separate patch.
>
> Ok. I'll split it.
>
> >
> > >  drivers/phy/hisilicon/phy-hi3670-usb3.c       | 98 +++++++++----------
> > >  2 files changed, 51 insertions(+), 51 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt
> > > index 4cb02612ff23..2fb27cb8beaf 100644
> > > --- a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt
> > > +++ b/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt
> > > @@ -2,7 +2,7 @@ Hisilicon Kirin970 usb PHY
> > >  -----------------------
> > >
> > >  Required properties:
> > > -- compatible: should be "hisilicon,kirin970-usb-phy"
> > > +- compatible: should be "hisilicon,hi3670-usb-phy"
> >
> > Unless this is unused, we can't just change it. It's an ABI.
>
> From upstream PoV, this binding is for a new driver that will be added
> via this patchset.

Please squash this change then.

Rob