[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200915165524.GA2115652@bogus>
Date: Tue, 15 Sep 2020 10:55:24 -0600
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh+dt@...nel.org>, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] ASoC: dt-bindings: Correct interrupt flags in examples
On Tue, 08 Sep 2020 16:59:54 +0200, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
>
> Correct the interrupt flags, assuming the author of the code wanted some
> logical behavior behind the name "ACTIVE_xxx", this is:
> ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
> Documentation/devicetree/bindings/sound/max98090.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5640.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5659.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5665.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5668.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5677.txt | 2 +-
> Documentation/devicetree/bindings/sound/rt5682.txt | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
Acked-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists