linux-kernel - Re: [PATCH] KVM: SVM: Get rid of the variable 'exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Sep 2020 10:58:39 -0700
From:   Krish Sadhukhan <krish.sadhukhan@...cle.com>
To:     lihaiwei.kernel@...il.com, x86@...nel.org, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     pbonzini@...hat.com, sean.j.christopherson@...el.com,
        vkuznets@...hat.com, wanpengli@...cent.com, jmattson@...gle.com,
        joro@...tes.org, tglx@...utronix.de, hpa@...or.com,
        Haiwei Li <lihaiwei@...cent.com>
Subject: Re: [PATCH] KVM: SVM: Get rid of the variable 'exit_fastpath'


On 9/15/20 4:30 AM, lihaiwei.kernel@...il.com wrote:
> From: Haiwei Li <lihaiwei@...cent.com>
>
> 'exit_fastpath' isn't used anywhere else, so remove it.
>
> Suggested-by: Krish Sadhukhan <krish.sadhukhan@...cle.com>
> Signed-off-by: Haiwei Li <lihaiwei@...cent.com>
> ---
>   arch/x86/kvm/svm/svm.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index c44f3e9..6e88658 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -3413,7 +3413,6 @@ static noinstr void svm_vcpu_enter_exit(struct kvm_vcpu *vcpu,
>   
>   static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu)
>   {
> -	fastpath_t exit_fastpath;
>   	struct vcpu_svm *svm = to_svm(vcpu);
>   
>   	svm->vmcb->save.rax = vcpu->arch.regs[VCPU_REGS_RAX];
> @@ -3536,8 +3535,7 @@ static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu)
>   		svm_handle_mce(svm);
>   
>   	svm_complete_interrupts(svm);
> -	exit_fastpath = svm_exit_handlers_fastpath(vcpu);
> -	return exit_fastpath;
> +	return svm_exit_handlers_fastpath(vcpu);
>   }
>   
>   static void svm_load_mmu_pgd(struct kvm_vcpu *vcpu, unsigned long root,
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@...cle.com>